[ 
https://issues.apache.org/jira/browse/DERBY-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013617#comment-13013617
 ] 

Kathey Marsden commented on DERBY-5084:
---------------------------------------

Well, one thing to consider is that neither of these cases were actually tested 
with the old test because it had in the ijConnName_sed.properties:
--
delete=ERROR 08001:*,ERROR XJ004:*

but both are perfectly valid cases that should be tested.
So I would say for the converted ijConnName test, keep the property 
ij.connection.connFour=jdbc:derby:nevercreated

and test that case.  


For ij.connection.connThree=jdbc:noone:fruitfly;create=true  , since the JVM 
messages differ I think we will need to think of  a different way to test that 
one outside of the master based ScriptTestCase.  I don't think it would be a 
major loss now with the conversion of this test as we are currrently deleting 
both these lines when run in the old harness.


> convert ijConnName.sql to a ScriptTest junit test
> -------------------------------------------------
>
>                 Key: DERBY-5084
>                 URL: https://issues.apache.org/jira/browse/DERBY-5084
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Myrna van Lunteren
>            Assignee: Houx Zhang
>            Priority: Trivial
>              Labels: derby_triage10_8
>         Attachments: DERBY-5084-1.patch, DERBY-5084-2.patch, 
> DERBY-5084-3.patch, DERBY-5084-3.stat, DERBY-5084.patch, DERBY-5084_4.diff, 
> ijConnName-1.out, ijConnName-1.tmp
>
>
> In DERBY-3089 it is mentioned that tools/ijConnName.sql should get converted 
> to a junit test, probably using ScriptTest.
> Making a separate issue so that that issue can be closed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to