[
https://issues.apache.org/jira/browse/DERBY-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025266#comment-13025266
]
Houx Zhang commented on DERBY-4443:
-----------------------------------
Hi, Bryan. I have only run the tools.Suite, but not suites.All.
After saw your adivce, I have run the complete test
(org.apache.derbyTesting.functionTests.suites.All. Is that right ?) sometimes
for several times, as been broken down by accident. The complete test suite
takes me more than 5 hours for one run.
I have seen the result containing some failures, but after run the complete
test suite and dividual tests on the original state, I believe they are not
caused by the new patch. So the new patch is OK.
> Wrap rollback in exception handlers in try-catch
> ------------------------------------------------
>
> Key: DERBY-4443
> URL: https://issues.apache.org/jira/browse/DERBY-4443
> Project: Derby
> Issue Type: Bug
> Components: Demos/Scripts, Documentation, Eclipse Plug-in, JDBC,
> Network Client, Network Server, Replication, Services, SQL, Test, Tools
> Affects Versions: 10.5.3.0
> Reporter: Aaron Digulla
> Assignee: Houx Zhang
> Labels: derby_triage10_8
> Attachments: DERBY-4443-1.patch, DERBY-4443-2.patch,
> DERBY-4443-3.patch, DERBY-4443-4.patch, DERBY-4443-4.png, DERBY-4443-5.patch,
> DERBY-4443-6-tmp.patch, DERBY-4443.patch, derby-4443-7.patch
>
>
> Avoid this pattern everywhere:
> }catch(SQLException se){
> //issue a rollback on any errors
> conn.rollback();
> throw se;
> }
> because an error in rollback will shadow the original exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
