[ https://issues.apache.org/jira/browse/DERBY-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025584#comment-13025584 ]
Bryan Pendleton commented on DERBY-4443: ---------------------------------------- Thank you Houx for the update. I understand about the tests; they take a very long time for me, too. I am hoping to set up a faster machine for running the tests sometime over the summer, but for now I am like you, it is quite hard to run the tests. So I don't run the full suite very often, but I do like to run it on a patch whenever I can. I am going to move ahead with committing patch 7. > Wrap rollback in exception handlers in try-catch > ------------------------------------------------ > > Key: DERBY-4443 > URL: https://issues.apache.org/jira/browse/DERBY-4443 > Project: Derby > Issue Type: Bug > Components: Demos/Scripts, Documentation, Eclipse Plug-in, JDBC, > Network Client, Network Server, Replication, Services, SQL, Test, Tools > Affects Versions: 10.5.3.0 > Reporter: Aaron Digulla > Assignee: Houx Zhang > Labels: derby_triage10_8 > Attachments: DERBY-4443-1.patch, DERBY-4443-2.patch, > DERBY-4443-3.patch, DERBY-4443-4.patch, DERBY-4443-4.png, DERBY-4443-5.patch, > DERBY-4443-6-tmp.patch, DERBY-4443.patch, derby-4443-7.patch > > > Avoid this pattern everywhere: > }catch(SQLException se){ > //issue a rollback on any errors > conn.rollback(); > throw se; > } > because an error in rollback will shadow the original exception. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira