[
https://issues.apache.org/jira/browse/DERBY-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180490#comment-13180490
]
Knut Anders Hatlen commented on DERBY-5536:
-------------------------------------------
The patch looks good to me.
Might be worthwhile adding a comment saying that the conversion
BigDecimal->BigInteger->BigDecimal in Decimal.getLong() is done to strip off
the fraction part.
Do the existing tests cover the case where a DECIMAL with non-zero scale and
non-zero fraction part is converted to long? The new test cases only test
numbers with no fraction part, I think.
> Client's ResultSet#getLong does not range check when converting from a
> DECIMAL column
> -------------------------------------------------------------------------------------
>
> Key: DERBY-5536
> URL: https://issues.apache.org/jira/browse/DERBY-5536
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Reporter: Dag H. Wanvik
> Attachments: MissingRangeCheck.java, derby-5536-2.diff,
> derby-5536-2.stat, derby-5536.diff, derby-5536.stat
>
>
> Derby's DECIMAL can contain an integer of 31 digits. This can overflow a
> long. The embedded JDBC driver catches this, but the client does not and can
> yield a corrupt long, cf enclosed repro.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
