[ 
https://issues.apache.org/jira/browse/DERBY-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182441#comment-13182441
 ] 

Knut Anders Hatlen commented on DERBY-5536:
-------------------------------------------

Thanks, Dag. The changes look good to me. Maybe the select statement in the new 
test case for non-zero fraction should have an ORDER BY clause to ensure stable 
results, since the rows are not guaranteed to be returned in insertion order? 
And perhaps factor out that test case in a separate test method? (The test 
method in which it is currently located, is actually for testing that the 
SQLStates are correct.)
                
> Client's ResultSet#getLong does not range check when converting from a 
> DECIMAL column
> -------------------------------------------------------------------------------------
>
>                 Key: DERBY-5536
>                 URL: https://issues.apache.org/jira/browse/DERBY-5536
>             Project: Derby
>          Issue Type: Bug
>          Components: JDBC, Network Client
>            Reporter: Dag H. Wanvik
>         Attachments: MissingRangeCheck.java, derby-5536-2.diff, 
> derby-5536-2.stat, derby-5536-3.diff, derby-5536-3.stat, derby-5536.diff, 
> derby-5536.stat
>
>
> Derby's DECIMAL can contain an integer of 31 digits. This can overflow a 
> long. The embedded JDBC driver catches this, but the client does not and can 
> yield a corrupt long, cf enclosed repro.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to