[
https://issues.apache.org/jira/browse/DERBY-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-2031:
-----------------------------------
Attachment: derby-2031-pre_with_git.stat
derby-2031-pre_with_git.diff
Attaching a partial patch showing what this would look like with an adapter in
the production jars.
How to evaluate:
Take a look at the class ProtocolTestAdapter and consider if you're comfortable
distributing this code with the production derbynet.jar file. Remember to take
into account the files that are removed from the same jar (TestFile and
TestProto) too.
The patch isn't complete, there's still some cleanup to do in the code running
the tests (i.e. the test will no longer be run with junit-pptesting). Note also
that the test code used Java 5 features, but I'm under the impression this test
can't run with J2ME anyway?
> Convert derbynet/testProtocol.java to JUnit
> -------------------------------------------
>
> Key: DERBY-2031
> URL: https://issues.apache.org/jira/browse/DERBY-2031
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Test
> Affects Versions: 10.3.1.4
> Reporter: Knut Anders Hatlen
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: d2031.diff, d2031.stat, derby-2031-1a-grammar_enum.diff,
> derby-2031-1a-grammar_enum.stat, derby-2031-2a-test.diff,
> derby-2031-3a-enable_test.diff, derby-2031-3a-enable_test.stat,
> derby-2031-3b-enable_test.diff, derby-2031-4a-close_streams.diff,
> derby-2031-pre_with_git.diff, derby-2031-pre_with_git.stat
>
>
> testProtocol.java executes DRDA commands from a file written in a
> special-purpose language. The statements are very much like assertions, so it
> should be fairly easy to convert the test to JUnit.
> Suggested approach: Change the interpreter (TestProto.java) so that is uses
> Assert.fail() instead of System.err.println() and System.exit(), and
> BaseTestCase.println() instead of System.out.println(). It should also use
> TestConfiguration to get the host name and port number.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
