[
https://issues.apache.org/jira/browse/DERBY-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-2031:
-----------------------------------
Attachment: derby-2031-5a-new_adapter.stat
derby-2031-5a-new_adapter.diff
Attaching patch 5a, which adds a new adapter, moves (or more correctly copies)
the test to the derbynet package, and adds it to the derbynet suite.
Follow-up patches will delete the old harness test and the package-private test.
The patch is dependent on DERBY-5631, so it'll have to sit around for a little
while.
To apply you need to do some svn stuff:
svn cp java/testing/org/apache/derby/impl/drda/ProtcolTest.java
java/testing/org/apache/derbyTesting/functionTests/tests/derbynet/ProtocolTest.java
&& cp /dev/null
java/testing/org/apache/derbyTesting/functionTests/tests/derbynet/ProtocolTest.java
svn cp
java/testing/org/apache/derbyTesting/functionTests/tests/derbynet/testProtocol.policy
java/testing/org/apache/derbyTesting/functionTests/tests/derbynet/ProtocolTest.policy
&& cp /dev/null
java/testing/org/apache/derbyTesting/functionTests/tests/derbynet/ProtocolTest.policy
I intend to commit this as soon as DERBY-5631 is in.
Patch ready for review.
> Convert derbynet/testProtocol.java to JUnit
> -------------------------------------------
>
> Key: DERBY-2031
> URL: https://issues.apache.org/jira/browse/DERBY-2031
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Test
> Affects Versions: 10.3.1.4
> Reporter: Knut Anders Hatlen
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.9.0.0
>
> Attachments: d2031.diff, d2031.stat, derby-2031-1a-grammar_enum.diff,
> derby-2031-1a-grammar_enum.stat, derby-2031-2a-test.diff,
> derby-2031-3a-enable_test.diff, derby-2031-3a-enable_test.stat,
> derby-2031-3b-enable_test.diff, derby-2031-4a-close_streams.diff,
> derby-2031-5a-new_adapter.diff, derby-2031-5a-new_adapter.stat,
> derby-2031-pre_with_git.diff, derby-2031-pre_with_git.stat
>
>
> testProtocol.java executes DRDA commands from a file written in a
> special-purpose language. The statements are very much like assertions, so it
> should be fairly easy to convert the test to JUnit.
> Suggested approach: Change the interpreter (TestProto.java) so that is uses
> Assert.fail() instead of System.err.println() and System.exit(), and
> BaseTestCase.println() instead of System.out.println(). It should also use
> TestConfiguration to get the host name and port number.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
