[
https://issues.apache.org/jira/browse/DERBY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410378#comment-13410378
]
Bryan Pendleton commented on DERBY-5847:
----------------------------------------
Regarding "if" statements which are never executed, my preference is to delete
the if statement
entirely, rather than commenting it out with more comments. We can always
recover the old
code from Subversion should we need it.
> Clean up IDE warnings in DRDAConnThread
> ---------------------------------------
>
> Key: DERBY-5847
> URL: https://issues.apache.org/jira/browse/DERBY-5847
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.10.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: d5847-1a-string-equality.patch,
> d5847-2a-unnecessary-return.patch, d5847-3a-static-fields-and-imports.patch,
> d5847-4a-unused-assignment.patch, d5847-5a-performance-warnings.patch,
> d5847-6a-obsolete-collection.patch, d5847-7a-sync-on-non-final.patch,
> d5847-8a-misc.patch, d5847-9a-this-leak.patch, d5847-9b-this-leak.patch
>
>
> When I open DRDAConnThread in NetBeans, I see 49 warnings. Most of them are
> harmless (like static fields accessed via an instance, suggestions about
> using StringBuilder instead of StringBuffer, or using System.arraycopy()
> instead of for loops). Others indicate real problems, like the use of != to
> compare SQL states in writeSQLDIAGGRP().
> We should clean up the warnings so that it's easier to notice new warnings
> about potential problems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
