[
https://issues.apache.org/jira/browse/DERBY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Anders Hatlen updated DERBY-5847:
--------------------------------------
Attachment: d5847-10a-overrides-and-braces.patch
Here's a patch (d5847-10a-overrides-and-braces.patch) that cleans up the last
batch of warnings that I see in my environment.
The patch adds an @Override annotation to the run() method, and addresses the
warnings about missing braces by adding braces or using existing helper methods
(like getDbName(), System.arraycopy() and Math.min()/max()) that make it
possible to eliminate the if/else statements and for loops that lack braces. It
also collapses an if/else statement in writeFdocaVal() with special cases for
Byte, Short an Integer into a single statement that uses the common super-class
Number.
All the regression tests passed with the patch.
> Clean up IDE warnings in DRDAConnThread
> ---------------------------------------
>
> Key: DERBY-5847
> URL: https://issues.apache.org/jira/browse/DERBY-5847
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.10.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: d5847-10a-overrides-and-braces.patch,
> d5847-1a-string-equality.patch, d5847-2a-unnecessary-return.patch,
> d5847-3a-static-fields-and-imports.patch, d5847-4a-unused-assignment.patch,
> d5847-5a-performance-warnings.patch, d5847-6a-obsolete-collection.patch,
> d5847-7a-sync-on-non-final.patch, d5847-8a-misc.patch, d5847-8b-misc.patch,
> d5847-9a-this-leak.patch, d5847-9b-this-leak.patch
>
>
> When I open DRDAConnThread in NetBeans, I see 49 warnings. Most of them are
> harmless (like static fields accessed via an instance, suggestions about
> using StringBuilder instead of StringBuffer, or using System.arraycopy()
> instead of for loops). Others indicate real problems, like the use of != to
> compare SQL states in writeSQLDIAGGRP().
> We should clean up the warnings so that it's easier to notice new warnings
> about potential problems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
