This patch [1] corrects the colours. Code review welcomed. This patch [2] swaps the alignment.
I've -2ed the 2nd patch. Let me know how you want to proceed with that. Jon [1] https://gerrit.wikimedia.org/r/157709 [2] https://gerrit.wikimedia.org/r/157709 On Fri, Aug 29, 2014 at 4:07 AM, Jared Zimmerman < [email protected]> wrote: > I think its ok to apply the mediawiki.ui styles but not reordering the > buttons. using constructive primary for Save, and putting the reset action > in either quiet or anchor destructive, I'm thinking anchor since the string > is so long right now. > > > > *Jared Zimmerman * \\ Director of User Experience \\ Wikimedia > Foundation > M +1 415 609 4043 \\ @jaredzimmerman <http://loo.ms/g0> > > > > On Thu, Aug 28, 2014 at 7:32 PM, Jon Robson <[email protected]> wrote: > >> On this basis should I not touch the order on the preferences form...? >> On 28 Aug 2014 18:01, "Jared Zimmerman" <[email protected]> >> wrote: >> >>> Steven I totally agree, I have a meeting with James/Editing team to talk >>> about instrumentation of the WTE which we'll need to move forward with a >>> good comparison here. I would say that we only need to prove that it is not >>> disruptive, rather than measurably better. Do you feel like we'll need to >>> do quantitative tests on every button group or just some key forms like >>> edit, account creation, and maybe one or two others? >>> >>> >>> >>> *Jared Zimmerman * \\ Director of User Experience \\ Wikimedia >>> Foundation >>> M +1 415 609 4043 \\ @jaredzimmerman <http://loo.ms/g0> >>> >>> >>> >>> On Thu, Aug 28, 2014 at 5:40 PM, Steven Walling <[email protected]> >>> wrote: >>> >>>> >>>> On Thu, Aug 28, 2014 at 4:53 PM, Jared Zimmerman < >>>> [email protected]> wrote: >>>> >>>>> 1) yes, the "primary action" will be rightmost, this could mean >>>>> progressive, in the case of a multi-step form form, destructive in the >>>>> case >>>>> of process where the primary function is to delete something and >>>>> constructive in the case of the final step in a single or multi-step >>>>> process that creates something or finalizes a non destructive process. >>>>> >>>>> 2) they should be ordered from right to left in order of importance >>>>> and frequency of use, there should only be one primary action. secondary >>>>> actions should have neutral or quiet appearance. >>>>> >>>>> We will capture as many patterns and best practices in the >>>>> mediawiki.ui living style guide as possible, however they will be a guide >>>>> and set of best practices, and there will likely be exceptions, and places >>>>> where the patterns break down. >>>>> >>>>> >>>>> Without completely redesigning the bottom of the wikitext editor, the >>>>> minimal mediawiki.ui version of the WTE bottom could go from >>>>> >>>>> [ Save Page ] [ Show Preview ] [ Show Changes ] Cancel >>>>> >>>>> to… >>>>> >>>>> *Cancel/Discard* (mw.destructive.quiet) *Show changes* >>>>> (mw.progressive.quiet) *Preview* (mw.progressive.quiet) *[ Save ]* >>>>> (mw.constructive.normal) >>>>> >>>> >>>> Whether we change to follow this pattern needs to validated with users >>>> before we attempt to standardize on it. If we're going to completely flip >>>> the order of our actions on forms then we need to demonstrate that it's >>>> worth it. >>>> >>>> >>>> >>>> -- >>>> Steven Walling, >>>> Product Manager >>>> https://wikimediafoundation.org/ >>>> >>>> _______________________________________________ >>>> Design mailing list >>>> [email protected] >>>> https://lists.wikimedia.org/mailman/listinfo/design >>>> >>>> >>> >>> _______________________________________________ >>> Design mailing list >>> [email protected] >>> https://lists.wikimedia.org/mailman/listinfo/design >>> >>> >> _______________________________________________ >> Design mailing list >> [email protected] >> https://lists.wikimedia.org/mailman/listinfo/design >> >> > > _______________________________________________ > Design mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/design > >
_______________________________________________ Design mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/design
