On Mon, 2007-01-15 at 19:02 -0600, Federico Mena Quintero wrote: > El lun, 15-01-2007 a las 16:31 +0000, Bastien Nocera escribió: > > On Mon, 2007-01-15 at 10:15 -0600, Federico Mena Quintero wrote: > > <snip> > > > We put a call to setrlimit() in gst-office-thumbnailer, so that the > > > helper convert(1) process is limited to 256 MB of memory and 5 seconds > > > of CPU time. Some files do *not* get thumbnailed, of course, but this > > > is better than making the machine unusable. > > > > Neat. I'll try and do something similar for Totem's thumbnailer (it > > currently uses a 30 sec time-limit, so it would be nice to also set a > > certain amount of CPU). > > The right fix is to put this in libgnomeui/gnome-thumbnail.c, so that > all thumbnailers get the same treatment. We just did this for > gsf-office-thumbnailer because it was super-urgent (patch attached). I > guess you could use a child_setup_func for g_spawn*() in gnome-thumbnail > to set up the resource limits :)
I don't think this is a great idea. 5 seconds to take a thumbnail of a movie can certainly feel a bit on the low side, depending on the speed of the machine at hand... _______________________________________________ desktop-devel-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/desktop-devel-list
