On Sun, Apr 02, 2017 at 09:53:41AM -0500, Michael Catanzaro wrote: > Simplest solution would be for Continuous to just pass --disable-Werror > to configure. OTOH I'm willing to change the Epiphany behavior if you > don't agree, but it's baked into use of AX_IS_RELEASE([git-directory]) > and AX_COMPILER_FLAGS, which to my understanding is the recommended set > of macros to use for GNOME modules. So we need to adjust that if we > want to change this. The behavior you want would require using > AX_IS_RELEASE([always]), which doesn't seem great to me. I think that's > the only way to get the behavior you want without totally dropping use > of AX_COMPILER_FLAGS, which we probably don't want to do. (Am I > mistaken?)
AX_IS_RELEASE([always]) might have unintended effects for other macros than AX_COMPILER_FLAGS. To disable -Werror by default it's better to set the IS-RELEASE parameter of AX_COMPILER_FLAGS to "yes": AX_COMPILER_FLAGS([WARN_CFLAGS], [WARN_LDFLAGS], [yes]) I think that's what I'll do in the modules I maintain, because I don't use -Werror, and there can be deprecation warnings that pop up at any time. -Werror is anyway disabled by default in Jhbuild, so I don't see why it should be enabled by default for other people not using Jhbuild and want to build the module from git. -- Sébastien _______________________________________________ desktop-devel-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/desktop-devel-list
