On 05/15/2013 02:28 PM, David Henningsson wrote: > This fixes a later assertion failure in module-stream-restore.
There were no comments, so I pushed this one now. > > Buglink: https://bugs.launchpad.net/bugs/896602 > Signed-off-by: David Henningsson <[email protected]> > --- > src/pulsecore/sink-input.c | 3 +++ > src/pulsecore/source-output.c | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/src/pulsecore/sink-input.c b/src/pulsecore/sink-input.c > index 6131bd3..8b9ee72 100644 > --- a/src/pulsecore/sink-input.c > +++ b/src/pulsecore/sink-input.c > @@ -376,6 +376,9 @@ int pa_sink_input_new( > data->save_volume = FALSE; > } > > + if (!data->volume_writable) > + data->save_volume = false; > + > pa_return_val_if_fail(pa_cvolume_compatible(&data->volume, > &data->sample_spec), -PA_ERR_INVALID); > > if (!data->muted_is_set) > diff --git a/src/pulsecore/source-output.c b/src/pulsecore/source-output.c > index d942419..96245c7 100644 > --- a/src/pulsecore/source-output.c > +++ b/src/pulsecore/source-output.c > @@ -309,6 +309,9 @@ int pa_source_output_new( > data->save_volume = FALSE; > } > > + if (!data->volume_writable) > + data->save_volume = false; > + > pa_return_val_if_fail(pa_cvolume_compatible(&data->volume, > &data->sample_spec), -PA_ERR_INVALID); > > if (!data->volume_factor_is_set) > -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic ** Changed in: pulseaudio (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/896602 Title: pulseaudio crashed with SIGABRT in subscribe_callback() Status in “pulseaudio” package in Ubuntu: Fix Committed Bug description: I see all the old bugs have a fix,,, well here it breaks again. ProblemType: Crash DistroRelease: Ubuntu 12.04 Package: pulseaudio 1:1.1-0ubuntu1 ProcVersionSignature: Ubuntu 3.2.0-1.3-generic 3.2.0-rc2 Uname: Linux 3.2.0-1-generic x86_64 NonfreeKernelModules: wl AlsaVersion: Advanced Linux Sound Architecture Driver Version 1.0.24. ApportVersion: 1.90-0ubuntu1 Architecture: amd64 ArecordDevices: **** List of CAPTURE Hardware Devices **** card 0: Intel [HDA Intel], device 0: CONEXANT Analog [CONEXANT Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 AudioDevicesInUse: USER PID ACCESS COMMAND /dev/snd/controlC0: siucdude 5677 F.... pulseaudio /dev/snd/pcmC0D0p: siucdude 5677 F...m pulseaudio Card0.Amixer.info: Card hw:0 'Intel'/'HDA Intel at 0xf4700000 irq 47' Mixer name : 'Conexant CX20561 (Hermosa)' Components : 'HDA:14f15051,17aa3c2b,00100000' Controls : 16 Simple ctrls : 8 CheckboxSubmission: 436b39225e95524b1259e913c38499a0 CheckboxSystem: 3e53d3ea5811723345f19eff5070f9ab Date: Sat Nov 26 10:04:15 2011 ExecutablePath: /usr/bin/pulseaudio InstallationMedia: Ubuntu 10.04 "Lucid Lynx" - Beta amd64 (20100318) ProcCmdline: /usr/bin/pulseaudio --start --log-target=syslog ProcEnviron: PATH=(custom, no user) LANG=en_US.UTF-8 SHELL=/bin/bash Signal: 6 SourcePackage: pulseaudio StacktraceTop: ?? () from /usr/lib/pulse-1.1/modules/module-stream-restore.so ?? () from /usr/lib/libpulsecore-1.1.so pa_mainloop_dispatch () from /usr/lib/x86_64-linux-gnu/libpulse.so.0 pa_mainloop_iterate () from /usr/lib/x86_64-linux-gnu/libpulse.so.0 pa_mainloop_run () from /usr/lib/x86_64-linux-gnu/libpulse.so.0 Title: pulseaudio crashed with SIGABRT in pa_mainloop_dispatch() UpgradeStatus: No upgrade log present (probably fresh install) UserGroups: adm admin cdrom dialout libvirtd lpadmin plugdev sambashare dmi.bios.date: 09/29/2009 dmi.bios.vendor: LENOVO dmi.bios.version: 0CCN58WW(V1.24) dmi.board.name: JIWA1 dmi.board.vendor: LENOVO dmi.board.version: REFERENCE dmi.chassis.asset.tag: No Asset Tag dmi.chassis.type: 10 dmi.chassis.vendor: No Enclosure dmi.chassis.version: N/A dmi.modalias: dmi:bvnLENOVO:bvr0CCN58WW(V1.24):bd09/29/2009:svnLENOVO:pn4151/200:pvrLenovo3000G530:rvnLENOVO:rnJIWA1:rvrREFERENCE:cvnNoEnclosure:ct10:cvrN/A: dmi.product.name: 4151/200 dmi.product.version: Lenovo 3000 G530 dmi.sys.vendor: LENOVO To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/896602/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
