(In reply to Dan Minor [:dminor] from comment #3) > Hi Gabriele, this code is our local modification to webrtc.org that we have > never merged upstream. As such, feel free to rewrite it to use poll() if that > will fix things. I'm not the original author, I just happened to do the last > upstream merge, so I can't comment on why select was chosen rather than poll. > :jesup might know if you want to follow up with him. > > One thing to be careful of is that this code is handling cameras being > plugged and unplugged which is not something we have coverage for in > automation, so you'll have to do some manual testing of your changes. The STR > from https://bugzilla.mozilla.org/show_bug.cgi?id=1581193#c0 might be helpful > here.
Thanks, I'll try to cook up a patch tomorrow. I must have a USB camera sitting around somewhere so testing shouldn't be a problem. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1849615 Title: WebRTC-related crashes Status in Mozilla Firefox: Confirmed Status in firefox package in Ubuntu: New Bug description: In Mozilla we've detected a spike of crashes in the Ubuntu-packaged version of Firefox 69.0.x. All the crashes are happening in the WebRTC code and specifically libc's FD_SET, FD_CLR and FD_ISSET range- checking safety is causing an abort. Is it possible that Firefox is being built with a FD_SETSIZE value that's different from what's used in libc? To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1849615/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
