Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/128#issuecomment-67983624
Definitely some good changes here, but do have some feedback before this
goes any further:
1. There are many style-only changes in this commit. Style-only changes are
fine, but they should be done as separate commits from those that change
behaviour.
2. ConfigParser is meant to be a re-usable helper class that would be
useful outside the context of cordova-lib. Because of this, it shouldn't have
any require()s for modules from the rest of cordova-lib. That means no calls to
"events.emit". Validation should be done in the parsers. If parsers are
duplicating code a bunch, then we should refactor them to either share via a
common base class, or by having helper classes / modules that they all depend
on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
