Github user MMrko commented on the pull request:
https://github.com/apache/cordova-lib/pull/128#issuecomment-68526026
Thanks for the feedback!
1. True, pardon my ignorance :) I removed the style-only changes
2. I moved the new functionality in to a separate [helper
module](/MMrko/cordova-lib/tree/fix-orientation-pref/cordova-lib/src/cordova/metadata/helpers/).
The platform parsers now use this helper module by inheriting a [base
parser](/MMrko/cordova-lib/tree/fix-orientation-pref/cordova-lib/src/cordova/metadata/parser.js),
which the helper module extends
The platform parsers required the most refactoring. Previously the methods
in each platform parser were assigned in a way that overrode the prototype.
This needed to be refactored to allow the platform parsers to inherit from a
base parser without overriding it (see
918b47eba0308869b38a91a83055c26c15791bb6).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
