Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/40#discussion_r28001029
  
    --- Diff: buildbot-conf/cordova.conf ---
    @@ -229,6 +229,8 @@ plugins_cleanup_steps = [
         NPMInstall(command=['shelljs'], what='shelljs'),
         RMRF('~/.cordova/*', description='removing cache', 
haltOnFailure=False),
         RMRF(BASE_WORKDIR + '/*', description='cleaning workspace', 
haltOnFailure=False),
    +    RMRF(BASE_WORKDIR + '/*', description='cleaning workspace again', 
haltOnFailure=False),
    +    RMRF(BASE_WORKDIR + '/*', description='cleaning workspace yet again', 
haltOnFailure=True),
    --- End diff --
    
    Both are functionally equivalent. I think the three repeated steps are a 
bit more clear, since it's very easy to see that it's repeated, and they make 
it evident on the waterfall page that this is something that still needs to be 
fixed properly.
    
    Also, we haven't seen this issue for `~/.cordova/*`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to