Github user dmitriy-barkalov commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/40#discussion_r28043272
  
    --- Diff: buildbot-conf/cordova.conf ---
    @@ -229,6 +229,8 @@ plugins_cleanup_steps = [
         NPMInstall(command=['shelljs'], what='shelljs'),
         RMRF('~/.cordova/*', description='removing cache', 
haltOnFailure=False),
         RMRF(BASE_WORKDIR + '/*', description='cleaning workspace', 
haltOnFailure=False),
    +    RMRF(BASE_WORKDIR + '/*', description='cleaning workspace again', 
haltOnFailure=False),
    +    RMRF(BASE_WORKDIR + '/*', description='cleaning workspace yet again', 
haltOnFailure=True),
    --- End diff --
    
    I think user of Buildbot can't fix issue inside Windows filesystem. So it 
is unnecessary to show that "something that still needs to be fixed properly" 
to him.
    
    Though we haven't seen the issue for `~/.cordova/*` it could happen. I 
assume that the cause of the issue is Windows filesystem and so `~/.cordova/*` 
and workspace folder have equal probability to have this issue.
    
    Also other developer could use `RMRF` function for removing other folders. 
It would be good to provide a solid solution to remove folder.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to