Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/185#discussion_r72956629
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -105,7 +105,7 @@ var handlers = {
var type = obj.type;
if(type === 'projectReference') {
- project.removeProjectReference(path.join(plugin.dir, src),
getTargetConditions(obj));
+ project.removeProjectReference(path.join('..', '..',
'plugins', plugin.id, src), getTargetConditions(obj));
--- End diff --
@daserge, please don't use hardcoded `../../plugins` path here. The idea
here is that PlatformApi abstracts from cordova project structure so we ideally
should not rely on presence of `plugins` directory two levels above. I'd rather
calculate relative path from `plugin.dir` using `path.relative`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
