Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/185#discussion_r73100316
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -105,7 +105,7 @@ var handlers = {
var type = obj.type;
if(type === 'projectReference') {
- project.removeProjectReference(path.join(plugin.dir, src),
getTargetConditions(obj));
+ project.removeProjectReference(path.join('..', '..',
'plugins', plugin.id, src), getTargetConditions(obj));
--- End diff --
Regarding `targetDir` - this is [not
supported](https://github.com/daserge/cordova-windows/blob/ee570036bc8faddc7d63e2830144c3d007d8e904/spec/unit/pluginHandler/windows.spec.js#L140)
for projectReferences.
Regarding hardcoded `../..` - using
`path.join(path.relative(project.projectFolder, plugin.dir), src)` instead is
causing some issues with tests related to project and plugin different drives
location, investigating.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
