[
https://issues.apache.org/jira/browse/DIRSHARED-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925878#action_12925878
]
Felix Knecht commented on DIRSHARED-64:
---------------------------------------
Thanks for pointing. IMO they don't interfere but are lacking the same 'enum'
problem. The States interface inherits 'implements' in several classes.
For IState we don't duplicate code when just merging IStates and
Dsmlv2StatesEnum, whereas this would be the case for States. So shall the
States stay an interface or shall States also be transformed to enum - meaning
merging States into all implementing classes and have there code duplicates?
Classes implementing States:
$ grep -r -l implements\ State .
./ldap/src/main/java/org/apache/directory/shared/asn1/codec/stateful/AbstractStatefulDecoder.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/search/controls/pagedSearch/PagedResultsControlStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/search/controls/entryChange/EntryChangeControlStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/search/controls/subentries/SubentriesControlStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/search/controls/persistentSearch/PersistentSearchControlStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/controls/replication/syncRequestValue/SyncRequestValueControlStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/controls/replication/syncInfoValue/SyncInfoValueControlStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/controls/replication/syncDoneValue/SyncDoneValueControlStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/controls/replication/syncmodifydn/SyncModifyDnControlStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/controls/replication/syncStateValue/SyncStateValueControlStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/controls/ppolicy/PasswordPolicyResponseControlStates.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/extended/operations/storedProcedure/StoredProcedureStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/extended/operations/gracefulShutdown/GracefulShutdownStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/extended/operations/cancel/CancelStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/extended/operations/certGeneration/CertGenerationStatesEnum.java
./ldap/src/main/java/org/apache/directory/shared/ldap/codec/extended/operations/gracefulDisconnect/GracefulDisconnectStatesEnum.java
> IStates and inherited interfaces/implementing classes shpuld be enums
> ---------------------------------------------------------------------
>
> Key: DIRSHARED-64
> URL: https://issues.apache.org/jira/browse/DIRSHARED-64
> Project: Directory Shared
> Issue Type: Improvement
> Affects Versions: 0.9.19
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.1.0
>
>
> We should transform this interface to be an Enum
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
