FYI: out trunk travis is green again: https://app.travis-ci.com/github/apache/httpd/builds/245924953
> Am 04.02.2022 um 17:05 schrieb Stefan Eissing <ste...@eissing.org>: > > > >> Am 04.02.2022 um 16:18 schrieb Yann Ylavic <ylavic....@gmail.com>: >> >> On Fri, Feb 4, 2022 at 1:22 PM <ic...@apache.org> wrote: >>> >>> Modified: httpd/httpd/trunk/modules/ssl/mod_ssl.c >>> URL: >>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/mod_ssl.c?rev=1897760&r1=1897759&r2=1897760&view=diff >>> ============================================================================== >>> --- httpd/httpd/trunk/modules/ssl/mod_ssl.c (original) >>> +++ httpd/httpd/trunk/modules/ssl/mod_ssl.c Fri Feb 4 12:22:26 2022 >>> @@ -690,80 +689,31 @@ static int ssl_hook_process_connection(c >>> { >> [] >>> temp = apr_brigade_create(c->pool, c->bucket_alloc); >>> + rv = ap_get_brigade(c->input_filters, temp, >>> + AP_MODE_INIT, APR_BLOCK_READ, 0); >>> + apr_brigade_destroy(temp); >>> >> [] >>> + if (APR_SUCCESS != APR_SUCCESS) { >> >> This one's unlikely to trigger :) >> >>> + if (c->cs) { >>> + c->cs->state = CONN_STATE_LINGER; >>> } >>> + ap_log_cerror(APLOG_MARK, APLOG_ERR, rv, c, APLOGNO(10373) >>> + "SSL handshake was not completed, " >>> + "closing connection"); >>> + return OK; >>> } >> [] >>> + >>> + return DECLINED; >>> } > > That was is my mistakes. I tried to rescue Graham's check on a failed > handshake. Maybe you can come up with an improvement on that... > >> >> Cheers; >> Yann.
