> On Sept. 25, 2014, 12:20 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/event.hpp, lines 23-24 > > <https://reviews.apache.org/r/25945/diff/1/?file=702991#file702991line23> > > > > Do you need this forward declaration? Or, can we remove the future.hpp > > include?
i think i need both due to circular dependencies. > On Sept. 25, 2014, 12:20 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/event.hpp, line 132 > > <https://reviews.apache.org/r/25945/diff/1/?file=702991#file702991line132> > > > > Do we want to add an explicit virtual destructor here per the other > > Events above? Ditto in PromiseDispatchEvent. nice catch - yes! > On Sept. 25, 2014, 12:20 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/event.hpp, line 184 > > <https://reviews.apache.org/r/25945/diff/1/?file=702991#file702991line184> > > > > Can you be more explicit with .get()? I'm looking at shared.hpp and > > seeing that we avoided the implicit bool operator. this is using std::shared_ptr or std::tr1::shared_ptr, not Shared (which should probably be deprecated?). i don't think there's any guidance about avoiding implicit boolean comparisons for pointers or smart pointers in our style guide, is there? Did I miss it? > On Sept. 25, 2014, 12:20 p.m., Ben Mahler wrote: > > src/tests/master_tests.cpp, lines 2355-2384 > > <https://reviews.apache.org/r/25945/diff/1/?file=702993#file702993line2355> > > > > Instead of writing an integration test within Mesos, what about writing > > some simple libprocess tests that demonstrate the added semantics of > > dispatch: > > > > (1) Process terminated: discarded. > > (2) Non-existent UPID: discarded. i'd like to keep both - ensure the promise is discarded, and have the Master test for regression testing. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25945/#review54571 ----------------------------------------------------------- On Oct. 3, 2014, 10:59 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25945/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 10:59 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1456 and MESOS-1751 > https://issues.apache.org/jira/browse/MESOS-1456 > https://issues.apache.org/jira/browse/MESOS-1751 > > > Repository: mesos-git > > > Description > ------- > > Create a PromiseDispatchEvent to allow discarding of promises if the > DispatchEvent can't be enqueued. > > Also converted some shared_ptr to Owned to correctly track ownership. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/c++11/dispatch.hpp > 76da2828cf36b6143d627dac66f3e0cc4416bae4 > 3rdparty/libprocess/include/process/defer.hpp > ebe6f2db47cab2a3306288d8ebabb720e7cd8976 > 3rdparty/libprocess/include/process/delay.hpp > 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 > 3rdparty/libprocess/include/process/dispatch.hpp > bceda2a2ae8963921e8e19660243a8644feab227 > 3rdparty/libprocess/include/process/event.hpp > bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 > 3rdparty/libprocess/src/process.cpp > d30ed636ee24d0fe6e62f69a921307bde1f32765 > 3rdparty/libprocess/src/tests/process_tests.cpp > b985fb77ea05fae5c0b144ea48814acc7bb5135b > src/tests/master_tests.cpp 705e5f2c0f9d693946e722cef63f38f3bff0d46b > > Diff: https://reviews.apache.org/r/25945/diff/ > > > Testing > ------- > > Added test that fails without the patch. > > Ran all tests (make check) with g++-4.4 and clang-3.5. > > > Thanks, > > Dominic Hamon > >
