----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25945/#review55373 -----------------------------------------------------------
Bad patch! Reviews applied: [26289, 25945] Failed command: git apply --index 25945.patch Error: error: patch failed: 3rdparty/libprocess/include/process/c++11/dispatch.hpp:5 error: 3rdparty/libprocess/include/process/c++11/dispatch.hpp: patch does not apply error: patch failed: 3rdparty/libprocess/include/process/defer.hpp:9 error: 3rdparty/libprocess/include/process/defer.hpp: patch does not apply error: patch failed: 3rdparty/libprocess/include/process/delay.hpp:5 error: 3rdparty/libprocess/include/process/delay.hpp: patch does not apply error: patch failed: 3rdparty/libprocess/include/process/dispatch.hpp:6 error: 3rdparty/libprocess/include/process/dispatch.hpp: patch does not apply error: patch failed: 3rdparty/libprocess/include/process/event.hpp:4 error: 3rdparty/libprocess/include/process/event.hpp: patch does not apply error: patch failed: 3rdparty/libprocess/src/process.cpp:57 error: 3rdparty/libprocess/src/process.cpp: patch does not apply - Mesos ReviewBot On Oct. 3, 2014, 5:59 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25945/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 5:59 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1456 and MESOS-1751 > https://issues.apache.org/jira/browse/MESOS-1456 > https://issues.apache.org/jira/browse/MESOS-1751 > > > Repository: mesos-git > > > Description > ------- > > Create a PromiseDispatchEvent to allow discarding of promises if the > DispatchEvent can't be enqueued. > > Also converted some shared_ptr to Owned to correctly track ownership. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/c++11/dispatch.hpp > 76da2828cf36b6143d627dac66f3e0cc4416bae4 > 3rdparty/libprocess/include/process/defer.hpp > ebe6f2db47cab2a3306288d8ebabb720e7cd8976 > 3rdparty/libprocess/include/process/delay.hpp > 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9 > 3rdparty/libprocess/include/process/dispatch.hpp > bceda2a2ae8963921e8e19660243a8644feab227 > 3rdparty/libprocess/include/process/event.hpp > bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 > 3rdparty/libprocess/src/process.cpp > d30ed636ee24d0fe6e62f69a921307bde1f32765 > 3rdparty/libprocess/src/tests/process_tests.cpp > b985fb77ea05fae5c0b144ea48814acc7bb5135b > src/tests/master_tests.cpp 705e5f2c0f9d693946e722cef63f38f3bff0d46b > > Diff: https://reviews.apache.org/r/25945/diff/ > > > Testing > ------- > > Added test that fails without the patch. > > Ran all tests (make check) with g++-4.4 and clang-3.5. > > > Thanks, > > Dominic Hamon > >
