tomaswolf commented on issue #473:

 itself is not a problem. I don't know why it was added or whether it is still 
necessary; I don't remember any bug report about that Karaf issue to Apache 
MINA SSHD. In any case, when `destroy(ChannelSession channel)` is called from 
Apache MINA SSHD, the SSH_MSG_CHANNEL_CLOSE exchange has been fully done. So 
unless you _know_ it's no longer needed and why I would recommend leaving line 
122 as is.
   I'm worried about [line 
 which passes this `destroy()` method as a "closeCallback". Without digging 
what where why and on which thread calls that closeCallback when, I would 
suspect that it gets invoked by Karaf while Apache MINA SSHD is still waiting 
for the client's SSH_MSG_CHANNEL_CLOSE to arrive. I would try passing `null` as 
a callback to `SessionFactory.create()` and leave the rest to the Apache MINA 
SSHD framework.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

For queries about this service, please contact Infrastructure at:

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to