MrEasy commented on issue #473:
URL: https://github.com/apache/mina-sshd/issues/473#issuecomment-1999359494

   Thanks for this hint!
   
   I was testing with having the closeCallback null in [line 
107](https://github.com/seeburger-ag/karaf/blob/96c71712f0e6989fdc04baa0051c375ba2bce6e4/shell/ssh/src/main/java/org/apache/karaf/shell/ssh/ShellFactoryImpl.java#L107),
 but that did not change anything for me.
   
   While looking around however, I came across closing of the session in 
ShellCommand and was wondering if there was accidentally the field named 
``session`` closed instead of local variable also named ``session``. Made this 
changes as a test: 
[code](https://github.com/apache/karaf/compare/main...seeburger-ag:karaf:sshd-473#diff-d54666ba52245136c2044113599bbea95e2bc1a1bb8e147d082c7f9ba2541fa7R150)
 and test works perfectly now - no wrong exit codes anymore. Now I'm not 
entirely sure this is the issue, maybe I just created a resource leak, but 
asked JB Onofré to share his thoughts on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to