[ 
https://issues.apache.org/jira/browse/TOMAHAWK-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609011#action_12609011
 ] 

Hazem Saleh commented on TOMAHAWK-1291:
---------------------------------------

When I checked the (HTMLTreeRenderer) yesterday, 

- I found many empty image alts + <td style="background: xxxx"/> instead of <td 
background="xxx"/>

for example)
out.writeAttribute(HTML.ALT_ATTR, "", null); // "alt" is a mandatory xhtml 
attribute
(((and))))
out.writeAttribute(HTML.STYLE_ATTR, "background-image:" + lineSrc + ";", null); 
//we use "style" because "background" is no valid xhtml attribute for td

and I saw other parts of the code that is not XHTML complaint and I think that 
Manfred was intending to fix these non complaint parts, so for the sake of 
consistency I followed the old pattern and fixed all the non complaint XHTML 
parts to solve the (TOMAHAWK-1143).

I really don't know what we should do (should we just warn users or not 
allowing the non-complaint XHTML).
We can check what other projects like Trinidad does.

Can we discuss this issue on the mailing list?

> t:graphicImage doesnot generate XHTML complaint code
> ----------------------------------------------------
>
>                 Key: TOMAHAWK-1291
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1291
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.7-SNAPSHOT
>            Reporter: Hazem Saleh
>            Assignee: Hazem Saleh
>             Fix For: 1.1.7-SNAPSHOT
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to