On Tue, Jul 22, 2008 at 9:30 PM, simon <[EMAIL PROTECTED]> wrote: > I was about to ask the same thing :-). > > Leonardo would be the expert on this, but I presume that the plugins at > http://svn.apache.org/repos/asf/myfaces/myfaces-build-tools/trunk/maven2-plugins/ > are identical in function to the ones at > http://svn.apache.org/repos/asf/myfaces/trinidad-maven/trunk/ > > I certainly haven't messed with them except to fix invalid headers. So > AFAIK they could be used to build Trinidad.
that would be great. I haven't "backported" all fixes from the Trinidad one, yet. but that is a piece of cake ;-) > > Hmm..as those header-fix patches haven't been applied to the > trinidad-maven dir, your new release does contain a few files that are > not have the proper license headers that the ASF requires. For example, > AbstractFacesMojo.java and a coupld of the pom.xml files. There are so > few that I don't think it's release critical but they should be fixed > sometime. ok, I think I know what files that are... sorry. I agree that this is not really critical. > > And yes IMO it would make more sense to have just one active development > line of this code. These plugins do seem to be generally useful, so to > me it would make sense to use the "generic" myfaces-build-tools ones in > future releases. It would involve a little bit more work to release them > though. You seem to be taking the approach currently of just releasing > the whole plugin batch, regardless of whether anything has changed, and > not bothering with release notes for any of them etc. When the plugins I use what JIRA offers, once the release is out. > are *only* used for trinidad then that is probably acceptable; if > trinidad passes its test suite then by definition the plugins are > working ok for their intended purpose. But that approach is probably a > little too casual for tools that can be used by multiple projects. > > Changing over doesn't seem worth doing right now; it would presumably > take a day or so to convert Trinidad over and verify they are all > working ok which would delay the release you're working on. > > By the way, I'm a little confused by your release procedure here. Your > email says that you are creating a 1.2.7 release. But: > * you've created a directory tags/maven-plugin-parent-1.2.7 yes, that what the release-plugin does for me. > (a) the name seems weird to me it creates a TAG out of the branch (or trunk) against which you run the plugin. > (b) it has been created although the vote has not yet passed the release is not out, yes. that is "just" the TAG (from the release:prepare task). When ever a release get's reverted, you can simple clean that (mess) up. > * you've created a "branches/matzew-1.2.7-release" directory, where the > pom has a version of 1.2.8-SNAPSHOT. What is this for? I always create a "private" branch to make sure I don't destroy the trunk ;-) So, if something went wrong during "mvn release:prepare" it is only broken on my private branch. > * you've created a "branches/1.2.7.1-branch" directory, where the pom > has a version of 1.2.7.1. What is this for? this is another private branch, which I once in a while create. Idea behind this is maintaining the 1.2.7 release. This was created by accident. Usually this is not needed on the plugins, but we had already a 1.x.y.1 release in the past... where something was really bad, but it wasn't worth to do a new 1.x.y+1 release. Does that make sense ? > > I see that the official repo has 1.2.6 as the latest, ie 1.2.7 is the > next expected release... true, once the vote has passed, the 1.2.7 is the next release -M > http://repo1.maven.org/maven2/org/apache/myfaces/trinidadbuild/maven-faces-plugin/ > > Regards, > Simon > > On Tue, 2008-07-22 at 19:47 +0200, Matthias Wessendorf wrote: >> Hi Leo / Simon, >> >> I know there is the "master myfaces build tool suite" :) >> I now wonder if the "maven-faces-plugin" is still working with Trinidad ? >> If so, I will test a separate Trinidad-Core branch to run against that >> in the future. >> Would be better, to use one toolset, right ? >> >> -Matthias >> >> On Tue, Jul 22, 2008 at 7:39 PM, Matthias Wessendorf <[EMAIL PROTECTED]> >> wrote: >> > Hi, >> > >> > I was running the needed tasks to get the 1.2.7 release of the Apache >> > MyFaces Trinidad Maven 2 Plugins out. >> > >> > The artifacts are deployed to my private Apache account ([1]). >> > >> > Please take a look at the "1.2.7" artifacts and vote. >> > >> > How to test those JARs ? >> > >> > Use the stage repo inside your pom.xml file: >> > ... >> > <pluginRepositories> >> > <pluginRepository> >> > <id>apache.stage</id> >> > <name>Apache Stage Repository</name> >> > <url>http://people.apache.org/~matzew/127-plugins</url> >> > <layout>default</layout> >> > </pluginRepository> >> > </pluginRepositories> >> > ... >> > >> > ------------------------------------------------ >> > [ ] +1 for community members who have reviewed and tested the bits >> > [ ] +0 >> > [ ] -1 for fatal flaws that should cause these bits not to be released, >> > and why.............. >> > ------------------------------------------------ >> > >> > Thanks, >> > Matthias >> > >> > [1] http://people.apache.org/~matzew/127-plugins >> > >> > -- >> > Matthias Wessendorf >> > >> > further stuff: >> > blog: http://matthiaswessendorf.wordpress.com/ >> > sessions: http://www.slideshare.net/mwessendorf >> > mail: matzew-at-apache-dot-org >> > >> >> >> > > -- Matthias Wessendorf further stuff: blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf mail: matzew-at-apache-dot-org
