On Tue, 2008-07-22 at 21:41 +0200, Matthias Wessendorf wrote:
> > By the way, I'm a little confused by your release procedure here. Your
> > email says that you are creating a 1.2.7 release. But:
> > * you've created a directory tags/maven-plugin-parent-1.2.7
>
> yes, that what the release-plugin does for me.
Then I guess I'm really complaining about how maven-release-plugin
works. We have a non-approved tag sitting right next to the approved
tags with absolutely no way for users to tell them apart, for the time
that it takes for the vote to either pass or fail. And using a weird dir
name. Doesn't seem like a sane approach to me. But that's really
off-topic for this vote; as you note it is maven-release-plugin doing
this.
>
> > (a) the name seems weird to me
>
> it creates a TAG out of the branch (or trunk) against which you run the
> plugin.
Ah, actually I think what maven-release-plugin is doing is using the
artifactId of the pom as the name of the new tag directory.
So what is really the issue is that the root pom here has a specific
name ("maven-plugin-parent") rather than a generic name ("plugins" or
similar).
Or the issue is maven-release-plugin's use of the pom artifactId as the
tag name. Did I mention that I think maven-release-plugin sucks? :-)
>
> > (b) it has been created although the vote has not yet passed
> the release is not out, yes. that is "just" the TAG (from the
> release:prepare task).
> When ever a release get's reverted, you can simple clean that (mess) up.
Yes. But it's just not clean to mix approved and unapproved stuff
together even if it can be "cleaned up" later. Not critical, but not
nice.
>
> > * you've created a "branches/matzew-1.2.7-release" directory, where the
> > pom has a version of 1.2.8-SNAPSHOT. What is this for?
>
> I always create a "private" branch to make sure I don't destroy the trunk ;-)
> So, if something went wrong during "mvn release:prepare" it is only broken
> on my private branch.
Ok. So this will be deleted when the vote has passed?
>
> > * you've created a "branches/1.2.7.1-branch" directory, where the pom
> > has a version of 1.2.7.1. What is this for?
>
> this is another private branch, which I once in a while create.
> Idea behind this is maintaining the 1.2.7 release. This was created
> by accident. Usually this is not needed on the plugins, but we had already
> a 1.x.y.1 release in the past... where something was really bad, but it wasn't
> worth to do a new 1.x.y+1 release. Does that make sense ?
Why not wait until it is needed before creating it? Less work, and less
confusion. When a critical patch is needed, can't the release tag be copied
into the branches dir as a base for the new work?
Cheers, Simon
>
