[
https://issues.apache.org/jira/browse/NUTCH-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881143#comment-13881143
]
Tejas Patil commented on NUTCH-1676:
------------------------------------
Hi [~markus17],
I tried out the patch with couple of https urls and it works correctly. Few
comments on the patch:
(1) In src/plugin/protocol-http/plugin.xml, the same stuff is repeated twice.
Not sure if that was accidental or meant to be different
{code:title=plugin.xml|borderStyle=solid}
+
+ <implementation id="org.apache.nutch.protocol.http.Http"
+ class="org.apache.nutch.protocol.http.Http">
+ <parameter name="protocolName" value="https"/>
+ </implementation>
+ <implementation id="org.apache.nutch.protocol.http.Http"
+ class="org.apache.nutch.protocol.http.Http">
+ <parameter name="protocolName" value="https"/>
+ </implementation>
{code}
(2) In HttpBase.java: The values in this line go till column 2070 and might be
painful while looking at the list. Is there any way to avoid it (maybe using a
String array) ?
{code:title=HttpBase.java|borderStyle=solid}
conf.getStrings("http.tls.supported.cipher.suites",
"TLS_ECDHE_ECDSA_WITH_AES_256_CBC....
{code}
(3) The class description is empty after the deletion of author tag. Can you
please fill that ?
{code:title=HttpBase.java|borderStyle=solid}
/**
*/
public abstract class HttpBase implements Protocol {
{code}
> Add rudimentary SSL support to protocol-http
> --------------------------------------------
>
> Key: NUTCH-1676
> URL: https://issues.apache.org/jira/browse/NUTCH-1676
> Project: Nutch
> Issue Type: Improvement
> Components: protocol
> Affects Versions: 1.7
> Reporter: Julien Nioche
> Fix For: 1.8
>
> Attachments: NUTCH-1676-2x.patch, NUTCH-1676.patch, NUTCH-1676.patch,
> NUTCH-1676.patch, NUTCH-1676.patch
>
>
> Adding https support to our http protocol would be a good thing even if it
> does not handle the security. This would save us from having to use the
> http-client plugin which is buggy in its current form.
> Patch generated from
> https://github.com/Aloisius/nutch/commit/d3e15a1db0eb323ccdcf5ad69a3d3a01ec65762c#commitcomment-4720772
> Needs testing...
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
