[
https://issues.apache.org/jira/browse/NUTCH-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452856#comment-17452856
]
Hudson commented on NUTCH-2911:
-------------------------------
FAILURE: Integrated in Jenkins build Nutch » Nutch-trunk #53 (See
[https://ci-builds.apache.org/job/Nutch/job/Nutch-trunk/53/])
fix for NUTCH-2911 contributed by prakharchaube (prakharchaube13:
[https://github.com/apache/nutch/commit/511e4a955d524494c4ffd1824b83406df5d1ae2b])
* (edit) src/java/org/apache/nutch/fetcher/Fetcher.java
NUTCH-2911: Caught and added log for InterruptedException (prakharchaube13:
[https://github.com/apache/nutch/commit/f7705b95ff96e7f16eb4bf8df38a1e4993abdd80])
* (edit) src/java/org/apache/nutch/fetcher/Fetcher.java
NUTCH-2911: Added InterruptedException to throws to allow propagation
(prakharchaube13:
[https://github.com/apache/nutch/commit/6662081bd3bf0d083fdf1b6be35aaa157034bd50])
* (edit) src/java/org/apache/nutch/fetcher/Fetcher.java
> Add cleanup call in Fetcher.java
> --------------------------------
>
> Key: NUTCH-2911
> URL: https://issues.apache.org/jira/browse/NUTCH-2911
> Project: Nutch
> Issue Type: Improvement
> Components: fetcher
> Affects Versions: 1.18
> Reporter: Prakhar Chaube
> Priority: Minor
> Labels: improvement
> Fix For: 1.19
>
>
> Fetcher's inner class, FetcherRun overrides Hadoop Mapper's run().
> Even though Nutch's FetcherRun doesn't need an explicit call the Mapper's
> cleanup() (Which is a blank function), it would increase the readability and
> completeness of the run Method to do so.
> Ideally, every implementation of Mapper is supposed to do the following tasks:
> 1. Perform Setup
> 2. Call map on the data set
> 3. Perform cleanups.
> Moreover, in case a custom Fetcher is written extending Fetcher.java cleanup
> could get easily missed out.
> PR for Fix: [here|https://github.com/apache/nutch/pull/708]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
