[
https://issues.apache.org/jira/browse/NUTCH-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453008#comment-17453008
]
Prakhar Chaube commented on NUTCH-2911:
---------------------------------------
Thanks [~snagel] for the merge, I see a Jenkins Build failure however checking
output looks like Test case in
[junit] Running org.apache.nutch.parse.tika.TestMSWordParser
[junit] Tests run: 14, Failures: 1, Errors: 0, Skipped: 4, Time elapsed: 5.656
sec
has failed, I doubt my change would have impacted this, do you see any concern
here?
> Add cleanup call in Fetcher.java
> --------------------------------
>
> Key: NUTCH-2911
> URL: https://issues.apache.org/jira/browse/NUTCH-2911
> Project: Nutch
> Issue Type: Improvement
> Components: fetcher
> Affects Versions: 1.18
> Reporter: Prakhar Chaube
> Priority: Minor
> Labels: improvement
> Fix For: 1.19
>
>
> Fetcher's inner class, FetcherRun overrides Hadoop Mapper's run().
> Even though Nutch's FetcherRun doesn't need an explicit call the Mapper's
> cleanup() (Which is a blank function), it would increase the readability and
> completeness of the run Method to do so.
> Ideally, every implementation of Mapper is supposed to do the following tasks:
> 1. Perform Setup
> 2. Call map on the data set
> 3. Perform cleanups.
> Moreover, in case a custom Fetcher is written extending Fetcher.java cleanup
> could get easily missed out.
> PR for Fix: [here|https://github.com/apache/nutch/pull/708]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
