[
https://issues.apache.org/jira/browse/NUTCH-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949025#comment-17949025
]
ASF GitHub Bot commented on NUTCH-2856:
---------------------------------------
lewismc commented on code in PR #826:
URL: https://github.com/apache/nutch/pull/826#discussion_r2072141544
##########
src/plugin/protocol-smb/ivy.xml:
##########
@@ -0,0 +1,54 @@
+<?xml version="1.0" ?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<ivy-module xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:noNamespaceSchemaLocation="http://ant.apache.org/ivy/schemas/ivy.xsd";
+ xmlns:ns0="http://ant.apache.org/ivy/maven"; version="2.0">
+ <info organisation="org.apache.nutch" module="${ant.project.name}">
+ <license name="Apache 2.0"/>
+ <ivyauthor name="Apache Nutch Team" url="http://nutch.apache.org"/>
+ <description>
+ Apache Nutch
+ </description>
+ </info>
+
+ <configurations>
+ <include file="../../..//ivy/ivy-configurations.xml"/>
+ </configurations>
+
+ <publications>
+ <!--get the artifact from our module name-->
+ <artifact conf="master"/>
+ </publications>
+
+ <dependencies>
+ <dependency org="com.hierynomus" name="smbj" rev="0.13.0"/>
+<!--
+ These dependencies are either contained in smbj (transitive) or
Review Comment:
We can just remove these comments.
##########
src/plugin/protocol-smb/src/test/org/apache/nutch/protocol/smb/TestSmbProtocol.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package plugin.protocol-smb.src.test.org.apache.nutch.protocol.smb;
+
+// Hadoop imports
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.Text;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class TestSmbProtocol {
+ protected static final Logger LOG =
LoggerFactory.getLogger(TestSmbProtocol.class);
+
+ @Before
+ public void setUp() {
+ LOG.warn("setUp()");
+ Assert.fail();
Review Comment:
These tests cannot be committed in the failing state. Thy will destabilize
the CI builds.
Previously I suggested using [test
containers](https://issues.apache.org/jira/browse/NUTCH-2856?focusedCommentId=17467111&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17467111).
If docker is not available on the host machine when tests are being run then
we could use the [@Testcontainers(disabledWithoutDocker =
true)](https://java.testcontainers.org/quickstart/junit_5_quickstart/#4-additional-attributes)
syntax.
##########
conf/log4j2.xml:
##########
@@ -25,7 +25,8 @@
<Appenders>
<RollingFile name="RollingFile"
fileName="${hadoop.log.dir}/${hadoop.log.file}"
filePattern="${hadoop.log.dir}/$${date:yyyy-MM}/nutch-%d{yyyy-MM-dd}.log.gz">
- <PatternLayout pattern="%d %p %c{1.} [%t] %m%n" />
+ <!--<PatternLayout pattern="%d %p %c{1.} [%t] %m%n" />-->
+ <PatternLayout pattern="%d %p %c [%t] %m%n" />
Review Comment:
@HiranChaudhuri please revert. Thank you
> Implement a protocol-smb plugin based on hierynomus/smbj
> --------------------------------------------------------
>
> Key: NUTCH-2856
> URL: https://issues.apache.org/jira/browse/NUTCH-2856
> Project: Nutch
> Issue Type: New Feature
> Components: external, plugin, protocol
> Reporter: Hiran Chaudhuri
> Assignee: Hiran Chaudhuri
> Priority: Major
> Fix For: 1.21
>
>
> The plugin protocol-smb advertized on
> [https://cwiki.apache.org/confluence/display/NUTCH/PluginCentral] actually
> refers to the JCIFS library. According to this library's homepage
> [https://www.jcifs.org/]:
> _If you're looking for the latest and greatest open source Java SMB library,
> this is not it. JCIFS has been in maintenance-mode-only for several years and
> although what it does support works fine (SMB1, NTLMv2, midlc, MSRPC and
> various utility classes), jCIFS does not support the newer SMB2/3 variants of
> the SMB protocol which is slowly becoming required (Windows 10 requires
> SMB2/3). JCIFS only supports SMB1 but Microsoft has deprecated SMB1 in their
> products. *So if SMB1 is disabled on your network, JCIFS' file related
> operations will NOT work.*_
> Looking at
> [https://en.wikipedia.org/wiki/Server_Message_Block#SMB_/_CIFS_/_SMB1:|https://en.wikipedia.org/wiki/Server_Message_Block#SMB_/_CIFS_/_SMB1]
> _Microsoft added SMB1 to the Windows Server 2012 R2 deprecation list in June
> 2013. Windows Server 2016 and some versions of Windows 10 Fall Creators
> Update do not have SMB1 installed by default._
> As a conclusion, the chances that SMB1 protocol is installed and/or
> configured are getting vastly smaller. Therefore some migration towards
> SMB2/3 is required. Luckily the JCIFS homepage lists alternatives:
> * [jcifs-codelibs|https://github.com/codelibs/jcifs]
> * [jcifs-ng|https://github.com/AgNO3/jcifs-ng]
> * [smbj|https://github.com/hierynomus/smbj]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
