[
https://issues.apache.org/jira/browse/NUTCH-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949349#comment-17949349
]
Lewis John McGibbney commented on NUTCH-2856:
---------------------------------------------
Hi [~hiranchaudhuri]
{quote}abc
{quote}
In an effort to encourage the development of unit tests for new contributions
(like this one) and to prevent regressions, we created guidance in the pull
request template
[https://github.com/apache/nutch/blob/master/.github/pull_request_template.md?plain=1#L10].
|https://github.com/apache/nutch/blob/master/.github/pull_request_template.md?plain=1#L10].]
Additionally, we have CI set up for both PR's
([https://github.com/apache/nutch/actions)] and post-merge
([https://ci-builds.apache.org/job/Nutch/job/Nutch-trunk/] ) which aims to
maintain 'stability'.
Your contribution is excellent and the project will accept it if feedback has
been addressed and tests are provided.
I can try to pick up your PR if you do not wish to continue work on it, Please
let us know.
May I offer some polite feedback. Just because your contribution has not been
merged 'yet' doesn't mean it will not be merged. I suspect that not many
committers are using Nutch to acquire data across the SMB protocol. I am trying
to work with you on that hence why I suggested we establish some unit testing
to boost the appeal of this PR. Thanks for your consideration.
> Implement a protocol-smb plugin based on hierynomus/smbj
> --------------------------------------------------------
>
> Key: NUTCH-2856
> URL: https://issues.apache.org/jira/browse/NUTCH-2856
> Project: Nutch
> Issue Type: New Feature
> Components: external, plugin, protocol
> Reporter: Hiran Chaudhuri
> Assignee: Hiran Chaudhuri
> Priority: Major
> Fix For: 1.21
>
>
> The plugin protocol-smb advertized on
> [https://cwiki.apache.org/confluence/display/NUTCH/PluginCentral] actually
> refers to the JCIFS library. According to this library's homepage
> [https://www.jcifs.org/]:
> _If you're looking for the latest and greatest open source Java SMB library,
> this is not it. JCIFS has been in maintenance-mode-only for several years and
> although what it does support works fine (SMB1, NTLMv2, midlc, MSRPC and
> various utility classes), jCIFS does not support the newer SMB2/3 variants of
> the SMB protocol which is slowly becoming required (Windows 10 requires
> SMB2/3). JCIFS only supports SMB1 but Microsoft has deprecated SMB1 in their
> products. *So if SMB1 is disabled on your network, JCIFS' file related
> operations will NOT work.*_
> Looking at
> [https://en.wikipedia.org/wiki/Server_Message_Block#SMB_/_CIFS_/_SMB1:|https://en.wikipedia.org/wiki/Server_Message_Block#SMB_/_CIFS_/_SMB1]
> _Microsoft added SMB1 to the Windows Server 2012 R2 deprecation list in June
> 2013. Windows Server 2016 and some versions of Windows 10 Fall Creators
> Update do not have SMB1 installed by default._
> As a conclusion, the chances that SMB1 protocol is installed and/or
> configured are getting vastly smaller. Therefore some migration towards
> SMB2/3 is required. Luckily the JCIFS homepage lists alternatives:
> * [jcifs-codelibs|https://github.com/codelibs/jcifs]
> * [jcifs-ng|https://github.com/AgNO3/jcifs-ng]
> * [smbj|https://github.com/hierynomus/smbj]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
