enapps-enorman commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/26#discussion_r1408492007
##########
src/main/java/org/apache/sling/servlets/post/impl/operations/DeleteOperation.java:
##########
@@ -69,6 +71,9 @@ protected void doRun(final SlingHttpServletRequest request,
final Iterator<Resource> res = getApplyToResources(request);
if (res == null) {
final Resource resource = request.getResource();
+ if (resource instanceof NonExistingResource) {
Review Comment:
I think this could still use some clarification about what should happen in
the alternate code path where the resources to delete are provided by one or
more ":applyTo" request parameters. If I am not mistaken, this looks like you
are only checking if the resource exists in the simple case where the resource
to delete is itself and no ":applyTo" arguments are provided?
##########
src/test/java/org/apache/sling/servlets/post/impl/operations/DeleteOperationTest.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.sling.servlets.post.impl.operations;
+
+import static org.junit.Assert.assertEquals;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.util.List;
+
+import org.apache.sling.api.SlingHttpServletRequest;
+import org.apache.sling.api.request.RequestPathInfo;
+import org.apache.sling.api.request.RequestProgressTracker;
+import org.apache.sling.api.resource.NonExistingResource;
+import org.apache.sling.api.resource.ResourceResolver;
+import org.apache.sling.servlets.post.PostResponse;
+import org.junit.Assert;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+public class DeleteOperationTest {
+
+ @Test
+ public void testDeletingNonExistingResource() throws Exception {
Review Comment:
Would also be good to have a test for the scenario where the (non-existing)
resource(s) to delete are provided via ":applyTo" request parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
