enapps-enorman commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/26#issuecomment-1834411480
@pat-lego After a closer look at this, it seems that any existing resources specified via ":applyTo" parameters would not get deleted after these changes since the applyTo resources iterator is consumed during the check to see if all are all existing. The second iteration would always be empty so no deleteResource calls would be performed. I discovered this while experimenting with new tests to improve the code coverage. I have fixed the problem and refactored a bit to remove duplication. I have committed the changes to this PR at 3e371ee for the others to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
