[ 
https://issues.apache.org/jira/browse/SLING-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213666#comment-14213666
 ] 

Stefan Seifert commented on SLING-4155:
---------------------------------------

yes, from my perspective that would be a good way.
the only drawback are the to annotation fields optional and isOptional - but 
that could be documented in the API.

an alternative would be another name like {{injectionStrategy}}, with values 
INHERIT, OPTIONAL, REQUIRED. this would be closer to the naming of 
defaultInjectionStrategy of the @Model annotation.

> DefaultInjectionStrategy not considered for injector-specific annotations
> -------------------------------------------------------------------------
>
>                 Key: SLING-4155
>                 URL: https://issues.apache.org/jira/browse/SLING-4155
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Sling Models Implementation 1.0.6
>            Reporter: Konrad Windszus
>
> The default injection strategy (being implemented in SLING-3696) is only 
> considered, in case there is no injector-specific annotation being used.
> Otherwise it is just ignored.
> The logic should be like this:
> if annotationProcessor.isOptional() returns null
> -> the default injection strategy should be used
> in any other case the boolean value should be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to