[
https://issues.apache.org/jira/browse/SLING-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214894#comment-14214894
]
Konrad Windszus commented on SLING-4155:
----------------------------------------
[[email protected]] Thanks for your input. I agree that
{{injectionStrategy}} is a better name. I would still need to increase the
version to 2.0.0 on {{org.apache.sling.models.spi.injectorspecific}}, because I
would need to add the {{getInjectionStrategy()}} method on the interface
{{InjectAnnotationProcessor}}. To make that backwards compatible one would need
to add an additional interface {{InjectAnnotationProcessor2}} which could then
have a method to retrieve the value from {{injectionStrategy}}.
That will still support the old {{InjectAnnotationProcessor}} with the known
limitations. But for all annotations being supported by Sling Models I could
implement the new interface, leveraging that additional field on the
annotation. WDYT?
> DefaultInjectionStrategy not considered for injector-specific annotations
> -------------------------------------------------------------------------
>
> Key: SLING-4155
> URL: https://issues.apache.org/jira/browse/SLING-4155
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Sling Models Implementation 1.0.6
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
>
> The default injection strategy (being implemented in SLING-3696) is only
> considered, in case there is no injector-specific annotation being used.
> Otherwise it is just ignored.
> The logic should be like this:
> if annotationProcessor.isOptional() returns null
> -> the default injection strategy should be used
> in any other case the boolean value should be used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
