GitHub user jmesmon opened a pull request:
https://github.com/apache/thrift/pull/1082
THRIFT-3828 In cmake avoid use of both quoted paths and SYSTEM with
include_directories()
This allows us to avoid issues where there are no paths to be added to
the include path (include_directories() errors when given an empty
string).
Specifically, gcc-6 requires that libraries stop passing paths like
'/usr/include' (or they will get libstdc++ build errors), so these paths
will be empty more often in the future.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesmon/thrift fix-includes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1082.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1082
----
commit b0c5e8c5c123fea57bd2780e66e0b25ac392ffe1
Author: Cody P Schafer <[email protected]>
Date: 2016-05-16T19:21:10Z
THRIFT-3828 In cmake avoid use of both quoted paths and SYSTEM with
include_directories()
This allows us to avoid issues where there are no paths to be added to
the include path (include_directories() errors when given an empty
string).
Specifically, gcc-6 requires that libraries stop passing paths like
'/usr/include' (or they will get libstdc++ build errors), so these paths
will be empty more often in the future.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
