[
https://issues.apache.org/jira/browse/TIKA-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173438#comment-16173438
]
ASF GitHub Bot commented on TIKA-2400:
--------------------------------------
ThejanW commented on a change in pull request #208: Fix for TIKA-2400
Standardizing current Object Recognition REST parsers
URL: https://github.com/apache/tika/pull/208#discussion_r140021556
##########
File path:
tika-parsers/src/main/java/org/apache/tika/parser/recognition/ObjectRecognitionParser.java
##########
@@ -83,12 +83,6 @@ public int compare(RecognisedObject o1, RecognisedObject
o2) {
}
};
- @Field
- private double minConfidence = 0.05;
Review comment:
Yeah, I have moved minConfidence logic to REST servers, it is kind of odd to
ask for topk objects from the backend and filter those objects again in the
client with related to minConfidence and select topN objects, just too much
logic in the client. we can directly ask the backend to give us topN objects
which has a confidence greater than the minConfidence, less iterations and
simplified client :100:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Standardizing current Object Recognition REST parsers
> -----------------------------------------------------
>
> Key: TIKA-2400
> URL: https://issues.apache.org/jira/browse/TIKA-2400
> Project: Tika
> Issue Type: Sub-task
> Components: parser
> Reporter: Thejan Wijesinghe
> Priority: Minor
> Fix For: 1.17
>
>
> # This involves adding apiBaseUris and refactoring current Object Recognition
> REST parsers,
> # Refactoring dockerfiles related to those parsers.
> # Moving the logic related to checking minimum confidence into servers
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
