[
https://issues.apache.org/jira/browse/TIKA-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176010#comment-16176010
]
ASF GitHub Bot commented on TIKA-2400:
--------------------------------------
ThejanW commented on a change in pull request #208: Fix for TIKA-2400
Standardizing current Object Recognition REST parsers
URL: https://github.com/apache/tika/pull/208#discussion_r140421441
##########
File path:
tika-parsers/src/main/java/org/apache/tika/parser/recognition/ObjectRecognitionParser.java
##########
@@ -83,12 +83,6 @@ public int compare(RecognisedObject o1, RecognisedObject
o2) {
}
};
- @Field
- private double minConfidence = 0.05;
Review comment:
yes, minConfidence and topN can be set through CLI/ Tika Config since we
have defined them in REST clients. In TensorflowRESTVideoRecogniser, you're
extending TensorflowRESTRecogniser, that's why I have made some of the fields
in TensorflowRESTRecogniser as protected(we need them there to derive apiUri
and healthUri).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Standardizing current Object Recognition REST parsers
> -----------------------------------------------------
>
> Key: TIKA-2400
> URL: https://issues.apache.org/jira/browse/TIKA-2400
> Project: Tika
> Issue Type: Sub-task
> Components: parser
> Reporter: Thejan Wijesinghe
> Priority: Minor
> Fix For: 1.17
>
>
> # This involves adding apiBaseUris and refactoring current Object Recognition
> REST parsers,
> # Refactoring dockerfiles related to those parsers.
> # Moving the logic related to checking minimum confidence into servers
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
