On Wed, Feb 11, 2009 at 6:38 AM, ant elder <[email protected]> wrote:
>
>
> On Wed, Feb 11, 2009 at 1:03 AM, Luciano Resende <[email protected]>
> wrote:
>>
>> Please review and vote on the 2.0-M1 release artifacts of Tuscany SCA for
>> Java.
>>
>> The artifacts are available for review at:
>> http://people.apache.org/~lresende/tuscany/2.0-M1-RC2/
>>
>> This includes the signed binary and source distributions, the RAT report,
>> and the Maven staging repository.
>>
>> The release tag is available at :
>> http://svn.apache.org/repos/asf/tuscany/tags/java/sca/2.0-M1-RC2/
>>
>>
>> Looks OK to me, here is my +1.
>>
>
> This is looking pretty close, one more RC and i think it will be perfect :-)
>
> - Didn't fix Rams RC1 comment about missing the RELEASE_NOTES and CHANGES
> file in the tag
>

This is now in the tag

> - The maven staging repository is missing the maven plugins
>

I've uploaded the maven plugins and sdo tools now.

> - I don't think the DWR binding needed to be excluded from the sc distro.
> Doesn't really matter either way but there is no harm in keeping it in and
> that way we avoid all the issues we've had in the past with the builds using
> complicated includes/excludes which end up going wrong
>

I'll consider this minor.

> - Something went wrong with the RAT report again and it would be good to
> have RAT reports for for both bin and src distro's. I ran some myself and
> found a cuople of issues:
>
> - sca-contribution.xsd in the eclipse plugin core module has an AL header
> instead of OASIS
>

The SCA Spec did not have schemas for sca-contribution.xsd, that's why
we have AL header.

> - There's a Constants class in the SCA-API module with an AL header, should
> this have a OASIS header or should the Constants class not be used? Need to
> check the specs but If the class isn't defined in a spec i think the class
> should be removed from the sca-api module.
>

Same here, this is a Tuscany constant class.

>    ...ant
>
>
>
>
>

Could we please continue the vote here ?

-- 
Luciano Resende
Apache Tuscany, Apache PhotArk
http://people.apache.org/~lresende
http://lresende.blogspot.com/

Reply via email to