We should definitely do the bug 989926 thing. I'll post a comment there. / Jonas
On Wed, Apr 23, 2014 at 2:38 PM, Kyle Machulis <[email protected]> wrote: > I proposed having a ril simulator 2 months ago (granted, at that time it was > going to be a node.js module that we could connect to via network, not > embedded in gecko, but I can see the worth in that idea too), and got nothing > but push back because we were "going to have tests on a publicly distributed > emulator" soon, so I dropped it. We still have no publicly distributed > emulator that I'm aware of. So have our thoughts changed on this? I was > prepared to do the work then, not sure I have time now but I do have ideas. > > ----- Original Message ----- >> From: "Vivien Nicolas" <[email protected]> >> To: [email protected] >> Sent: Wednesday, April 23, 2014 4:13:08 AM >> Subject: Re: [b2g] Using mocks in integration tests >> >> I would really like to not use any mock for integration tests. Mocks is >> fine for unit tests, but does not really makes sense for integration tests. >> >> If somone has the necessary cycles for that, I would like to push for >> bug 989926, so you can use mozMobileConnection (or any RIL interfaces), >> directly. >> >> On 22/04/2014 19:01, Dale Harvey wrote: >> > Hah cool thanks, good catch >> > >> > Same question applies :) >> > >> > >> > On 22 April 2014 17:02, Gabriele Svelto <[email protected] >> > <mailto:[email protected]>> wrote: >> > >> > On 22/04/2014 17:08, Dale Harvey wrote: >> > > >> > >> > https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/sim_dialog_test.js >> > > I would like to use one of the 3 mocks for mozMobileConnection >> > > >> > >> > https://github.com/mozilla-b2g/gaia/blob/master/shared/test/unit/mocks/mock_navigator_moz_mobile_connection.js >> > > preferably >> > >> > Actually that's deprecated since navigator.mozMobileConnection is gone, >> > replaced by the navigator.mozMobileConnections array when DSDS support >> > was introduced. You should use >> > >> > https://github.com/mozilla-b2g/gaia/blob/master/shared/test/unit/mocks/mock_navigator_moz_mobile_connections.js >> > instead (note the final 's'). We're trying to get rid of the former >> > file >> > but it's still used here and there. >> > >> > Gabriele >> > >> > >> > >> > >> > _______________________________________________ >> > dev-b2g mailing list >> > [email protected] >> > https://lists.mozilla.org/listinfo/dev-b2g >> > >> _______________________________________________ >> dev-b2g mailing list >> [email protected] >> https://lists.mozilla.org/listinfo/dev-b2g >> > _______________________________________________ > dev-b2g mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-b2g _______________________________________________ dev-b2g mailing list [email protected] https://lists.mozilla.org/listinfo/dev-b2g
