Hello,
Thanks for putting work into the build system.
On 8/5/14 4:51 PM, John Ford wrote:
...snip...
> My plan is to:
>
> 1) create b2g-scripts repository, containing the B2G.git/scripts
> directory
> 2) create b2g-tools repository, containing the B2G.git/tools
> directory
> 3) move all scripts in the root of B2G.git into b2g-scripts
> 4) use repo file copy operations (like we do for the root Makefile)
> to copy those scripts back into the root of the source tree
> 5) remove the device configuration part of config.sh
> 6) create a new script, config-device.sh in b2g-scripts that has the
> device configuration steps.
> 7) have config.sh call config-device.sh after the source tree is
> initialized
...snip...
> Please let me know if you have any thoughts on this issue.
...snip...
In step 3, is there any chance the scripts could be segregated or at
least given a name which suggests where they apply? The current B2G has
scripts that run for backup, for the build, at runtime for performance
and some I did not take the time to decipher. We would all benefit from
having the purpose of the scripts self-evident either by their name or
location.
Why step 4? Why allow any scripts in the root of the workspace? Is this
merely to avoid having to clean them up, because they 'belong' to other
folk, or for some technical reason?
Given that 'repo' is a tool to enable everyone to have a build system
which is also a developer workspace, proper etiquette (and good working
habits) would be to keep this directory CLEAN. Ideally, the working
directory would go from
1. empty (or with a single bootstrap script)
2. filled with B2G contents
3. additionally with source code directories
4. additionally with build directories
and then alternate between 3 (after a clean) and 4 (after a build) with
edits to source all in the directories from steps 2 or 3. All files in
the root directory would be a developer's own files they use for their
own work. The B2G build system, built on repo, is totally complex and
not yet documented; keeping the layout clean can only help.
I would propose ruthlessly moving all the scripts into a
b2g-scripts/unsorted/ directory and require those who use such scripts
to give them some attention. This would include a clear name (as per the
previous paragraph), proper copyright and licensing info, a link to
documentation if any, and contact info for issues.
Steps 5-7 begin a cleanup of the build scripts themselves a much bigger
topic.
cheers,
~adrian
_______________________________________________
dev-b2g mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-b2g
