Hi Adrian, Thank you for your response. I'll respond inline.
John On Aug 8, 2014, at 6:10 AM, Adrian Custer <[email protected]> wrote: > In step 3, is there any chance the scripts could be segregated or at least > given a name which suggests where they apply? The current B2G has scripts > that run for backup, for the build, at runtime for performance and some I did > not take the time to decipher. We would all benefit from having the purpose > of the scripts self-evident either by their name or location. We could give them different names in the b2g-scripts repository and copy them into the root of the tree using repo with their current name. > Why step 4? Why allow any scripts in the root of the workspace? Is this > merely to avoid having to clean them up, because they 'belong' to other folk, > or for some technical reason? Nope, it's not to avoid any work and actually increases the complexity of this project. The main reason to leave them there is that they are the known and documented interface points to the build system. Breaking people's workflow and all of our build documentation is a big deal. Doing it the way that I have proposed lets us compartmentalize these changes. We can fix the source management separate to changing the build system interfaces. Implementing my plan means that we get all the wins of having a managed B2G.git repository without the churn of changing documentation and mind share of developers. This change will also make it a lot easier to deploy future changes to the B2G.git scripts because we'll get B2G updates on every source tree update instead of when someone remembers to run 'git pull origin/master' in their B2G.git clone. > Given that 'repo' is a tool to enable everyone to have a build system which > is also a developer workspace, proper etiquette (and good working habits) > would be to keep this directory CLEAN. Ideally, the working directory would > go from > 1. empty (or with a single bootstrap script) > 2. filled with B2G contents > 3. additionally with source code directories > 4. additionally with build directories > and then alternate between 3 (after a clean) and 4 (after a build) with edits > to source all in the directories from steps 2 or 3. All files in the root > directory would be a developer's own files they use for their own work. The > B2G build system, built on repo, is totally complex and not yet documented; > keeping the layout clean can only help. I think this is a style issue. I won't stop you from proposing this change, I just don't think we should tie it in with the separate proposal to fix the source management aspects of B2G.git. > I would propose ruthlessly moving all the scripts into a > b2g-scripts/unsorted/ directory and require those who use such scripts to > give them some attention. This would include a clear name (as per the > previous paragraph), proper copyright and licensing info, a link to > documentation if any, and contact info for issues. > > Steps 5-7 begin a cleanup of the build scripts themselves a much bigger topic. Steps 5-7 don't clean up the scripts, it does just enough to split config.sh into the source management component and device configuration component. Overall, I think this change will make cleaning up B2G.git scripts significantly easier in the future. > > cheers, > ~adrian _______________________________________________ dev-b2g mailing list [email protected] https://lists.mozilla.org/listinfo/dev-b2g
