Don't worry: the reviewer just set r- to my second patch to set it as default, although there are no reasons in the comment (just a "No"). I've left a NI to ask if the not-default patch is good for him.
However I think it's an issue that full cloning is OK while shallow one is not. I would do some check for that. 2015-05-14 3:37 GMT+08:00 Juan Antonio Aguilera Tamayo <[email protected]>: > I have the same error for KEON, I see that is for Geekphone devices, the > log... > > ..................................................................................................................................................................... > > env REPO_INIT_FLAGS="--depth=1" REPO_SYNC_FLAGS="-j10" ./config.sh keon > > ...................................................................................................................................................................... > > Fetching projects: 92% (86/93) From > git://codeaurora.org/platform/external/svox > * [new branch] ics_strawberry -> caf/ics_strawberry > Fetching projects: 93% (87/93) error: Cannot fetch > platform/external/sqlite > From git://github.com/gp-b2g/gp-keon-kernel > * [new branch] master -> gp-b2g/master > Fetching projects: 94% (88/93) From http://git.mozilla.org/releases/gecko > * [new branch] master -> mozillaorg/master > Fetching projects: 95% (89/93) From > git://github.com/gp-b2g/frameworks_base > * [new branch] master -> gp-b2g/master > Fetching projects: 96% (90/93) From http://git.mozilla.org/releases/gaia > * [new branch] master -> mozillaorg/master > Fetching projects: 97% (91/93) From > git://codeaurora.org/quic/qrd-android/platform/prebuilt > * [new branch] ics_master_qrd_101 -> QRD/ics_master_qrd_101 > Fetching projects: 98% (92/93) > error: Exited sync due to fetch errors > Repo sync failed > > > > > > > 2015-05-13 13:32 GMT-04:00 Jovan Gerodetti <[email protected]>: > >> I'm trying to fetch a new clone of the source tree with this command: >> >> REPO_INIT_FLAGS="--depth=1" BRANCH=v2.2 ./config.sh peak >> >> but it always fails: >> >> Jovans-MacBook-Air:B2G Jovan$ REPO_INIT_FLAGS="--depth=1" BRANCH=v2.2 >> ./config.sh peak >> Get git://github.com/mozilla-b2g/b2g-manifest >> From git://github.com/mozilla-b2g/b2g-manifest >> * [new branch] master -> origin/master >> * [new branch] revert-203-bug1025788-v2 -> >> origin/revert-203-bug1025788-v2 >> * [new branch] revert-226-v1.3t -> origin/revert-226-v1.3t >> * [new branch] revert-316-bug-1149387 -> >> origin/revert-316-bug-1149387 >> * [new branch] v1-train -> origin/v1-train >> * [new branch] v1.0.0 -> origin/v1.0.0 >> * [new branch] v1.0.1 -> origin/v1.0.1 >> * [new branch] v1.1.0hd -> origin/v1.1.0hd >> * [new branch] v1.2 -> origin/v1.2 >> * [new branch] v1.2f -> origin/v1.2f >> * [new branch] v1.3 -> origin/v1.3 >> * [new branch] v1.3t -> origin/v1.3t >> * [new branch] v1.4 -> origin/v1.4 >> * [new branch] v2.0 -> origin/v2.0 >> * [new branch] v2.1 -> origin/v2.1 >> * [new branch] v2.1s -> origin/v2.1s >> * [new branch] v2.2 -> origin/v2.2 >> * [new tag] B2G_1_0_1_20130213094222 -> B2G_1_0_1_20130213094222 >> * [new tag] B2G_1_1_0_hd_20130530182315 -> >> B2G_1_1_0_hd_20130530182315 >> * [new tag] B2G_1_1_0_hd_20130530182315_BASE -> >> B2G_1_1_0_hd_20130530182315_BASE >> * [new tag] closing-nightly -> closing-nightly >> >> Your identity is: Jovan Gerodetti <[email protected]> >> If you want to change this, please re-run 'repo init' with --config-name >> >> repo has been initialized in /Users/Jovan/Peak/B2G >> Fetching project external_compat-wireless >> Fetching project platform/external/fdlibm >> Fetching project platform/external/bluetooth/hcidump >> Fetching project platform/external/tremolo >> Fetching project platform/libcore >> Fetching project platform/external/tinyalsa >> Fetching project platform/external/bluetooth/glib >> Fetching project hardware_ril >> Fetching project platform/bionic >> error: Cannot fetch platform/external/bluetooth/hcidump >> Fetching project platform/external/gtest >> error: Cannot fetch platform/libcore >> error: Cannot fetch hardware_ril >> error: Cannot fetch platform/external/bluetooth/glib >> error: Cannot fetch external_compat-wireless >> error: Cannot fetch platform/external/fdlibm >> error: Cannot fetch platform/bionic >> error: Cannot fetch platform/external/tremolo >> error: Cannot fetch platform/external/tinyalsa >> error: Cannot fetch platform/external/gtest >> >> error: Exited sync due to fetch errors >> Repo sync failed >> >> Does it not work with the peak configuration? >> >> >> Regards, >> Jovan >> >> >> 2015-05-13 5:47 GMT+02:00 Greg Weng <[email protected]>: >>> >>> I've submit the new patch which set shallow cloning as default option: >>> >>> https://bugzilla.mozilla.org/show_bug.cgi?id=1161909#c7 >>> >>> Since I don't know if the reviewer has other concerns I submit a new >>> patch instead of deprecating the old one. >>> >>> 2015-05-12 23:40 GMT+08:00 Greg Weng <[email protected]>: >>> > I agree with you. The reason I didn't set it as default option is >>> > because I don't know whether it would be used. So if in this thread >>> > people don't have any opinion against that, I would update the patch. >>> _______________________________________________ >>> dev-gaia mailing list >>> [email protected] >>> https://lists.mozilla.org/listinfo/dev-gaia >> >> >> >> _______________________________________________ >> dev-gaia mailing list >> [email protected] >> https://lists.mozilla.org/listinfo/dev-gaia >> > _______________________________________________ dev-b2g mailing list [email protected] https://lists.mozilla.org/listinfo/dev-b2g
