On Mon, Mar 24, 2014 at 03:43:26PM +0400, izbyshev wrote:
> Hello,
>
> I found a bug in configure.in around line 2640:
>
> ac_cv_have_visibility_builtin_bug=no
> if ! ${CC-cc} ${CFLAGS} ${DSO_PIC_CFLAGS}
> ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
> ac_cv_have_visibility_builtin_bug=yes
> else
> if test `grep -c "@PLT" conftest.S` = 0; then
> ac_cv_visibility_builtin_bug=yes
> fi
> fi
>
> The second 'if' uses a wrong variable name, so the result of 'grep' is
> effectively ignored. The problem is that if I fix this bug, clang (3.4.1)
> fails this test (it optimizes all code out with -O2), the configuration
> variables (related to -fvisibility) are changed accordingly, and then a
> simple firefox build fails. The same bug is also in js/src/configure.in.
>
> Is this configure check really relevant now? The fact that it is always
> successfully passed by any compiler that can somehow compile the conftest.c
> and that it has not been fixed since its introduction in 2006 probably shows
> that no. Does anybody have ideas about what should be done with it, if any?
Its certainly obsolete at this point however, its always failed on mac,
so we use -fvisibility=hidden instead of system wrappers there. We'd
like to switch to using -fvisibility=hidden everywhere, but doing that
means I need to get around to figuring out why it adds ~7000 relocations
compared to the system wrappers.
Trev
> _______________________________________________
> dev-builds mailing list
> [email protected]
> https://lists.mozilla.org/listinfo/dev-builds
_______________________________________________
dev-builds mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-builds
