izbyshev wrote:
Is this configure check really relevant now? The fact that it is always
successfully passed by any compiler that can somehow compile the conftest.c
and that it has not been fixed since its introduction in 2006 probably shows
that no. Does anybody have ideas about what should be done with it, if any?
Interesting, that check was actually important for GCC versions which
didn't obey visibility flags properly, but I don't actually know which
ones those are any more... I think it was <4.2. It probably doesn't
matter any more, but we might want to explicitly blacklist the known-bad
GCC versions.
On 3/24/2014 8:51 AM, Trevor Saunders wrote:
Its certainly obsolete at this point however, its always failed on mac,
so we use -fvisibility=hidden instead of system wrappers there. We'd
like to switch to using -fvisibility=hidden everywhere, but doing that
means I need to get around to figuring out why it adds ~7000 relocations
compared to the system wrappers.
We would not like to use -fvisibility=hidden everywhere!
-fvisibility=hidden is strictly worse than using the pragmas because it
only affects symbol generation and doesn't affect symbol resolution.
This means that we still have to use dynamic relocations against
internal symbols when we should be using hidden relocations (on ELF
platforms). It doesn't matter nearly as much or at all on Mach-O/PE
which use startup relocations instead of a GOT/PLT.
--BDS
_______________________________________________
dev-builds mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-builds
