On 2015/06/17 22:57, Philip Chee wrote:
On 17/06/2015 00:19, ISHIKAWA, Chiaki wrote:
Ouch.
Obviously that the patch files are applied in the order of
its FILENAME'S SORTING ORDER.Upper case comes before lowercase, too.
My memory is a little bit rusty, but there was
no requirement for the name of the patches such that the alphanumerical
sorting of the mozilla-*.patch filename must be in the order that the
patches are applied.
Since this is just a try build, you could fold all your mozilla-central
patches into one.
Phil
On 2015/06/17 22:57, Philip Chee wrote:> On 17/06/2015 00:19, ISHIKAWA,
Chiaki wrote:
>
>> Ouch.
>> Obviously that the patch files are applied in the order of
>> its FILENAME'S SORTING ORDER.Upper case comes before lowercase, too.
>>
>> My memory is a little bit rusty, but there was
>> no requirement for the name of the patches such that the alphanumerical
>> sorting of the mozilla-*.patch filename must be in the order that the
>> patches are applied.
>
> Since this is just a try build, you could fold all your mozilla-central
> patches into one.
>
> Phil
>
You are right!
However, I modified my script for tryserver submission, and the
submission now works (!).
(Also, I wanted to keep the patches separate since this is a preparation
to ask for a review of a lengthy steps of patches to take care of the
missing I/O checks of C-C TB.
I wanted to show exactly what happens after applying the patches.
I am glad I did this. There was one Windows compilation issue.
A type cast does not work in Windows build whereas it did in linux build.)
_______________________________________________
dev-builds mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-builds
