Hi Manuel, Tomas,

I agree with Manuel here. Solution A) Because MS/MRS must be considered meta 
data now and I don't think we should store 'translated' meta data in database. 
It will make it more confusing. 

If needed we should make extra convenience methods to translate the result set.

Regards,

Erik Kort


-----Ursprüngliche Nachricht-----
Von: [email protected] 
[mailto:[email protected]] Im Auftrag von Manuel Reiß
Gesendet: Montag, 16. November 2009 10:11
An: [email protected]
Betreff: Re: [oxid-dev-general] Multilanguage salutation

Hi Tomas,
thx for sharing your thoughts and giving us the opportunity to contribute.
In my opinion you should stick to your first plan - solution A :)
It'll give you more flexibility and power (imagine a newsletter/gift to all
customers who have ever ordered sth. in your shop or any other fancy
marketing stuff - take a look at the queries if you wanna send flowers to
your female customers only ;) ).

my 2 cents... 

Manuel Reiß

-----Ursprüngliche Nachricht-----
Von: [email protected]
[mailto:[email protected]] Im Auftrag von Tomas
Liubinas
Gesendet: Freitag, 13. November 2009 17:53
An: [email protected]
Betreff: [oxid-dev-general] Multilanguage salutation

Hi,

For some time I've been working on old bug #535 (User salutation
internationalization)
https://bugs.oxid-esales.com/view.php?id=535 

I would like to fix it once and for all, but the solution is getting a
bit fuzzy. This is what I did. First of all I replaced all oxuser table
oxsal field values to multilanguage constants MR and MRS. They are
translated in front end and you always see correct Herr and Frau (in
german case) values. By switching shop languages salutation is also
translated. I tried to implement it as robust as possible, so unexpected
salutation value should make no harm. And this works fine.

What is not really clear for me is oxorder table. When order entry is
created, related oxuser information is copied to oxorder table. I need
your opinion on what to do with oxsal field here. Imo there are 2
options:

A. we can just copy multilang constant (MR/MRS) to oxorder table oxsal
field. This way it would be easier to handle salutations in
international environment.

B. We just can save translated value (Herr/Frau) to order table. First
of all for 3rd party software it would be more convenient to access
order data not caring about any translations. Also as order information
is more supposed to be read rather edited, having native salutation
there probably would never harm. 

My initial implementation was based on option A, but the more I think
option B seems to be more appropriate solution. 

So any opinions or suggestions from your side?

Regards
Tomas Liubinas
_______________________________________________
dev-general mailing list
[email protected]
http://dir.gmane.org/gmane.comp.php.oxid.general

_______________________________________________
dev-general mailing list
[email protected]
http://dir.gmane.org/gmane.comp.php.oxid.general
_______________________________________________
dev-general mailing list
[email protected]
http://dir.gmane.org/gmane.comp.php.oxid.general

Reply via email to